Change Nushell activation script to module #2422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaborbernat
reviewed
Sep 17, 2022
This was referenced Sep 20, 2022
|
@kubouch shall we proceed here? |
|
Yes, this is still intended to be merged, I just didn't find the time to finish the activation command being a list. |
gaborbernat
approved these changes
Nov 27, 2022
github-actions bot
added a commit
to MaRDI4NFDI/open-interfaces
that referenced
this pull request
Nov 28, 2022
Bumps [virtualenv](https://github.com/pypa/virtualenv) from 20.16.7 to 20.17.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/pypa/virtualenv/releases">virtualenv's releases</a>.</em></p> <blockquote> <h2>20.17.0</h2> <h2>What's Changed</h2> <ul> <li>release 20.16.7 by <a href="https://github.com/gaborbernat"><code>@gaborbernat</code></a> in <a href="https://github-redirect.dependabot.com/pypa/virtualenv/pull/2445">pypa/virtualenv#2445</a></li> <li>Change Nushell activation script to module by <a href="https://github.com/kubouch"><code>@kubouch</code></a> in <a href="https://github-redirect.dependabot.com/pypa/virtualenv/pull/2422">pypa/virtualenv#2422</a></li> <li>Fix operator in Nushell activation script by <a href="https://github.com/kubouch"><code>@kubouch</code></a> in <a href="https://github-redirect.dependabot.com/pypa/virtualenv/pull/2450">pypa/virtualenv#2450</a></li> <li>Do not use deprecated API by <a href="https://github.com/gaborbernat"><code>@gaborbernat</code></a> in <a href="https://github-redirect.dependabot.com/pypa/virtualenv/pull/2448">pypa/virtualenv#2448</a></li> <li>Bump setuptools by <a href="https://github.com/gaborbernat"><code>@gaborbernat</code></a> in <a href="https://github-redirect.dependabot.com/pypa/virtualenv/pull/2451">pypa/virtualenv#2451</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/pypa/virtualenv/compare/20.16.7...20.17.0">https://github.com/pypa/virtualenv/compare/20.16.7...20.17.0</a></p> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/pypa/virtualenv/blob/main/docs/changelog.rst">virtualenv's changelog</a>.</em></p> <blockquote> <h2>v20.17.0 (2022-11-27)</h2> <p>Features - 20.17.0</p> <pre><code>- Change Nushell activation script to be a module meant to be activated as an overlay. (`[#2422](pypa/virtualenv#2422) <https://github.com/pypa/virtualenv/issues/2422>`_) - Update operator used in Nushell activation script to be compatible with future versions. (`[#2450](pypa/virtualenv#2450) <https://github.com/pypa/virtualenv/issues/2450>`_) <p>Bugfixes - 20.17.0 </code></pre></p> <ul> <li>Do not use deprecated API from <code>importlib.resources</code> on Python 3.10 or later - by :user:<code>gaborbernat</code>. (<code>[#2448](pypa/virtualenv#2448) <https://github.com/pypa/virtualenv/issues/2448></code>_)</li> <li>Upgrade embedded setuptools to <code>65.6.3</code> from <code>65.5.1</code> - by :user:<code>gaborbernat</code>. (<code>[#2451](pypa/virtualenv#2451) <https://github.com/pypa/virtualenv/issues/2451></code>_)</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/pypa/virtualenv/commit/33e7b9db29e93493e695f929767a27f007d31f4c"><code>33e7b9d</code></a> release 20.17.0</li> <li><a href="https://github.com/pypa/virtualenv/commit/7cb7e63e749c17a9b8e2d37616189f5d9e079251"><code>7cb7e63</code></a> Bump setuptools (<a href="https://github-redirect.dependabot.com/pypa/virtualenv/issues/2451">#2451</a>)</li> <li><a href="https://github.com/pypa/virtualenv/commit/9bc1f9fb98fe2766a4f2c69f9738f89e3ce2cef0"><code>9bc1f9f</code></a> Do not use deprecated API (<a href="https://github-redirect.dependabot.com/pypa/virtualenv/issues/2448">#2448</a>)</li> <li><a href="https://github.com/pypa/virtualenv/commit/4961931fe6497efb619f21983a8da4ee9ef04240"><code>4961931</code></a> Fix operator in Nushell activation script (<a href="https://github-redirect.dependabot.com/pypa/virtualenv/issues/2450">#2450</a>)</li> <li><a href="https://github.com/pypa/virtualenv/commit/ffa04ae837c1821a118ca501180005e85cc40d08"><code>ffa04ae</code></a> Change Nushell activation script to module (<a href="https://github-redirect.dependabot.com/pypa/virtualenv/issues/2422">#2422</a>)</li> <li><a href="https://github.com/pypa/virtualenv/commit/e6925a6afbb88fdaa7af9e57016f8c53c4359aee"><code>e6925a6</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/pypa/virtualenv/issues/2445">#2445</a> from pypa/release-20.16.7</li> <li>See full diff in <a href="https://github.com/pypa/virtualenv/compare/20.16.7...20.17.0">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The activation script will be a module that would be added as an overlay which allows for more ergonomic handling of the environment varaibles.
I had to change the
sourceactivation command tooverlay usebecause that's how you activate overlay in Nushell. However, it required me to also disable quoting of the command. By default, the Python activator would create'overlay use'and try to call that as a command but in Nushell, commands are called without quotes.Thanks for contributing, make sure you address all the checklists (for details on how see development documentation)!
tox -e fix_lint)docs/changelogfolder